Skip to content

Conversation

ABESTM
Copy link
Contributor

@ABESTM ABESTM commented Oct 13, 2025

Adds support for USB on STM32U083 discovery board.
It also modifies HSI48 device tree definition.

Copy link
Contributor

@mathieuchopstm mathieuchopstm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM functionally. Tiny risk of clash with RNG configuration since mux is shared, which should be addressed by:

@erwango erwango added this to the v4.3.0 milestone Oct 15, 2025
Copy link
Contributor

@etienne-lms etienne-lms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor issue: there are 2 typos in the commit message for commit
"boards: st: stm32u83c_dk: Add USB support":
replace stm32u83c_dk with stm32u083c_dk (an 0 is missing).

@ABESTM ABESTM force-pushed the stm32u083c_dk_usb branch from 39e305e to def3c53 Compare October 15, 2025 15:16
@ABESTM
Copy link
Contributor Author

ABESTM commented Oct 15, 2025

Minor issue: there are 2 typos in the commit message for commit "boards: st: stm32u83c_dk: Add USB support": replace stm32u83c_dk with stm32u083c_dk (an 0 is missing).

Thank you. I updated the commit message.

@ABESTM
Copy link
Contributor Author

ABESTM commented Oct 16, 2025

Waiting for #96353 to be merged. already merged

@ABESTM ABESTM force-pushed the stm32u083c_dk_usb branch from 7a28859 to b4cd999 Compare October 16, 2025 14:14
Copy link
Contributor

@etienne-lms etienne-lms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor comments, otherwise LGTM.

Could you update the commit messages:

-dts: stm32u0: Move HSI48 to USB capable STM32U0 family
+dts: arm: st: stm32u0: Move HSI48 to USB capable STM32U0 family
 
-HSI48 is not available on all families.
+HSI48 is not available on all families, only on those where USB is present.
-Also add option to calibrate from USB SOF.
dts: arm: st: stm32u0: Add CK48 multiplexer

Adds CK48 mutliplexer for STM32U0 families.
-HSI48 is moved to USB capable families.

Note: dts: arm: st: stm32u0: could be shortened to dts: arm: st: u0:.

HSI48 is not available on all families, only on those where USB is present.

Signed-off-by: Adam BERLINGER <[email protected]>
Adds CK48 mutliplexer for STM32U0 families.

Signed-off-by: Adam BERLINGER <[email protected]>
Adds USB Device support to stm32u083c_dk board

Signed-off-by: Adam BERLINGER <[email protected]>
@ABESTM ABESTM force-pushed the stm32u083c_dk_usb branch from b4cd999 to ce395dc Compare October 17, 2025 11:54
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants