-
Notifications
You must be signed in to change notification settings - Fork 8.1k
boards: st: stm32u83c_dk: Add USB support #97486
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM functionally. Tiny risk of clash with RNG configuration since mux is shared, which should be addressed by:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor issue: there are 2 typos in the commit message for commit
"boards: st: stm32u83c_dk: Add USB support":
replace stm32u83c_dk
with stm32u083c_dk
(an 0
is missing).
39e305e
to
def3c53
Compare
Thank you. I updated the commit message. |
def3c53
to
7a28859
Compare
|
7a28859
to
b4cd999
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor comments, otherwise LGTM.
Could you update the commit messages:
-dts: stm32u0: Move HSI48 to USB capable STM32U0 family
+dts: arm: st: stm32u0: Move HSI48 to USB capable STM32U0 family
-HSI48 is not available on all families.
+HSI48 is not available on all families, only on those where USB is present.
-Also add option to calibrate from USB SOF.
dts: arm: st: stm32u0: Add CK48 multiplexer
Adds CK48 mutliplexer for STM32U0 families.
-HSI48 is moved to USB capable families.
Note: dts: arm: st: stm32u0:
could be shortened to dts: arm: st: u0:
.
HSI48 is not available on all families, only on those where USB is present. Signed-off-by: Adam BERLINGER <[email protected]>
Adds CK48 mutliplexer for STM32U0 families. Signed-off-by: Adam BERLINGER <[email protected]>
Adds USB Device support to stm32u083c_dk board Signed-off-by: Adam BERLINGER <[email protected]>
b4cd999
to
ce395dc
Compare
|
Adds support for USB on STM32U083 discovery board.
It also modifies HSI48 device tree definition.